[MPlayer-dev-eng] [PATCH] fix for unconditional use of PATH_MAX

Robert Millan zeratul2 at wanadoo.es
Thu May 1 14:35:01 CEST 2003

On Wed, Apr 30, 2003 at 07:39:27PM +0200, Fabian Franz wrote:
> I think we should stick to what we have now and just add, what I mentioned adn 
> no it is no security risk, see Tobias Mail, about it.

please don't do that, it's a _bad_ solution. what if i run mplayer in
a directory longer than 512 bytes? then it will fail or not work as

if you hardcode PATH_MAX, you'll recieve bug reports from users telling
that mplayer fails or behaves unexpectedly.

if you don't want to stick with two code snippets (one for PATH_MAX and
other for non-PATH_MAX), then just use dynamic allocation as someone
suggested before. that will work for all systems.

Robert Millan

make: *** No rule to make target `war'.  Stop.

Another world is possible - Just say no to genocide

More information about the MPlayer-dev-eng mailing list