[MPlayer-dev-eng] [PATCH] dvb-input menu and more fixes

Alban Bedel albeu at free.fr
Wed May 7 18:30:15 CEST 2003


Hi Nico,

on Tue, 06 May 2003 00:03:45 +0200 you wrote:

> Hi,
> sorry to pester you with another patch, but this time I removed all the 
> hacks and added a menu of channels.
> 
> It's for MPlayer-20030505.

After a quick look, both the stream part and the menu look ok to me.
Beside that you may want to put your name instead of mine in the
author fields ;)
I saw this wich look like a 10L too :
+static void dvbin_close(dvb_priv_t *priv)
 {
[....]
+	
+	return 1;
+}

Also pls try to remove as much cosmetics as possible from your patchs,
in particular if they are meant to be applied to CVS.
	Albeu



More information about the MPlayer-dev-eng mailing list