[MPlayer-dev-eng] [PATCH] PowerPC ffmpeg fixes

Dan Christiansen danchr at daimi.au.dk
Mon May 12 17:58:14 CEST 2003


On Monday, May 12, 2003, at 12:59 PM, Alex Beregszaszi wrote:

> Hi,
>
> this hasn't got much sense, please fix the possible bugs instead
> commenting
> the whole optimization codes out!
>
> You've disabled the altivec-enabled idct code too, thats bad!

I'd suspect that there are far more MPlayer users who run Darwin on 
their PowerPC than Linux. I don't have a G4 myself, but I'm quite sure 
it wouldn't go undetected if the code crashed on Darwin. If you want to 
disable it, at least make it #ifdef SYS_LINUX or something.

I agree that simply disabling buggy code isn't the right way to go, 
though. If everyone did that, there would be no Windows ;)

- Dan



More information about the MPlayer-dev-eng mailing list