[MPlayer-dev-eng] vo_xv broken

Alex Beregszaszi alex at fsn.hu
Thu May 15 19:39:34 CEST 2003


today I came across a huge bug.
The problem: -vo xv crashes togethet with vd_lcl (-vc mpzlib) playing a
test movie avizlib_sample.avi (it crashes after draw_image). It plays
fine with -vo x11.

So I looked at that draw_image, and there's inside an exception against
BGR24, AHHA, so it calls rgb24toyv12 natively! Why does it supports
that? Anyway, that should be fine - disabling it, everything worked
(-vop scale got called).

Then I ran -vo xv with an mpeg1 together with -vop format=bgr24, 
to see if -vo xv works with bgr24, and it does! Why? Becouse the new
swscale calls sws_rgb2rgb_init() once, so the rgb24toyv12 will be set.
So one should call that function in the vo_xv init.

Michael: what should be the proper wise? I vote for removing all
the conversions from the vo's.
Also vo_x11 needs a cleanup, as it uses swscale, but that's ok,
using swscale is a bit better than using those rgb2rgb funcs.

btw, have you seen this (http://cdslash.net/gallery/trinity) yet?:)
(sshnuke -rootpw="Z1010101" ownz!)

Alex Beregszaszi <alex at fsn.hu>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)

More information about the MPlayer-dev-eng mailing list