libvo/ cleanup (Re: [MPlayer-dev-eng] vo_xv broken)

Joey Parrish joey at
Sun May 18 09:07:44 CEST 2003

On Sat, May 17, 2003 at 01:50:58AM -0400, D Richard Felker III wrote:
> > I would like to volunteer to clean fbdev, but I have no time until next
> > week.  If anyone else wants to do it before then, that's fine too.
> Go for it! I looked at it a while back, but was too disgusted to touch
> it. :)

Wow.  So, now I've poked at vo_fbdev.c some.  There's a whole lot more
code than I expected to see.  Is anybody going to be upset if the first
version I send in has fewer features?  What I'm saying is that I don't
think I can clean it up without removing a lot of it.  How about writing
it as vo_fbdev2 and porting features over from vo_fbdev one at a time?
And rather than commit yet another vo sequel, just test it that way as a
patch, then let it replace the current vo_fbdev once it implements all
the same features.  Does this seem reasonable?


More information about the MPlayer-dev-eng mailing list