[MPlayer-dev-eng] [PATCH] two small fixes for vo_xv

[Attila Kinali]

On 13 May 2003 13:47:08 +0100
Tom Lees <tal26 at cam.ac.uk> wrote:


> 1. Starting in fullscreen e.g. (mplayer -fs dvd://1) will have a window
> which doesn't extend all the way down the screen unless you have a 4:3
> movie.

I cant reproduce it. -fs works fine for me with xv.
 
> 2. Monitoraspect is not used so e.g. showing a movie when in 1280x1024
> desktop looks wrong.

This is handled by libvo/aspect.c and is for all -vo modules the same.
I cant see there a bug. Cant test it either as i dont have a setup
with a non-4:3 resolution. Can anyone confirm this.

> 
> 
> [t.t.xv.diff  text/x-patch (1255 bytes)]
> Index: vo_xv.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libvo/vo_xv.c,v
> retrieving revision 1.139
> diff -u -r1.139 vo_xv.c
> --- vo_xv.c	24 Apr 2003 19:07:46 -0000	1.139
> +++ vo_xv.c	13 May 2003 13:20:16 -0000
> @@ -310,9 +310,9 @@
>    {
>     hint.x = vo_dx;
>     hint.y = vo_dy;
> +   aspect(&d_width,&d_height,A_NOZOOM);
>     hint.width = d_width;
>     hint.height = d_height;
> -   aspect(&d_width,&d_height,A_NOZOOM);

This makes somewhat sense, on the other hand, it worked
fine until now...

>  #ifdef HAVE_XF86VM
>      if ( vm )
>        {
> @@ -382,10 +382,13 @@
>          XSetWMNormalHints( mDisplay,vo_window,&hint );
>  	XMapWindow(mDisplay, vo_window);
>  	if ( flags&1 ) vo_x11_fullscreen();
> +	else
> +	{
>  #ifdef HAVE_XINERAMA
>  	vo_x11_xinerama_move(mDisplay,vo_window);
>  #endif
>  	vo_x11_sizehint( hint.x, hint.y, hint.width, hint.height,0 );
> +	}
>      } else  {
>  	// vo_fs set means we were already at fullscreen
>  	vo_x11_sizehint( hint.x, hint.y, hint.width, hint.height,0 );
> 

This is bad, this will disable the xinerama code if the movie is shown
full screen. (or do you really want to splitt the movie over several
monitors ?)

			Attila Kinali


-- 
Emacs ist für mich kein Editor. Für mich ist das genau das gleiche, als wenn
ich nach einem Fahrrad (für die Sonntagbrötchen) frage und einen pangalaktischen
Raumkreuzer mit 10 km Gesamtlänge bekomme. Ich weiß nicht, was ich damit soll.
		-- Frank Klemm, de.comp.os.unix.discussion