[MPlayer-dev-eng] PATCH: signal handling in gmplayer, immediate mode in tvi_v4l, wrong warning for tv:// MRLs

Sergey Pinaev dfo at antex.ru
Tue May 20 11:08:33 CEST 2003

On Tue, 20 May 2003 10:50:59 +0200
Arpi <arpi at thot.banki.hu> wrote:

>> MJ> 1: mp_msg() in gmplayer uses GTK message boxes, and this is REALLY a
>> MJ> stupid idea inside a signal handler! This makes gmplayer 'almost
>> mp_msg() in signal handler is stupid idea even without gui =/

A> hmm, i tend to agree :)
A> so feel free to change it... to fprintf maybe
A> btw gui users won't know what happened to mplayer when it crashing,
A> but who cares :)

according to "info libc" fprintf is nonreentrant and should not
be used in signal handlers.
btw, exit_sighandler in mplayer.c is "bloated" =)
i think it should be implemented as is in mencoder.c
(no, i cannot do it, because it lead to modifying of main() in
mplayer.c and i simple cannot read and understand ~2.5K lines
long function with tons of #ifdef's =/)

mail="Sergey Pinaev <dfo at antex.ru>"
url="http://`echo $mail | sed 's/.* <\(.*\)>/\1/' | sed 's/@/./'`"

More information about the MPlayer-dev-eng mailing list