[MPlayer-dev-eng] PATCH: signal handling in gmplayer, immediate mode in tvi_v4l, wrong warning for tv:// MRLs

Sergey Pinaev dfo at antex.ru
Tue May 20 13:31:33 CEST 2003


hi.
On Tue, 20 May 2003 13:15:18 +0200
Michael Joosten <joost at c-lab.de> wrote:

>> "good" way should be to set signal handler with sigaction() and
>> set sa_mask to block all signals during handler excution and
>> replace mp_msg's in exit_sighandler with printf("we are dead\n").
>> exit_player() should also be replaced with exit()...

MJ> Perhaps one should differentiate between the 'ugly' signals and 
MJ> the external signals. Just 'exit()ing' is somewhat dangerous for 
MJ> stuff like tvi_v4l (tuner cards with external audio cable), 
MJ> because you want to switch/restore some stuff into the original 
MJ> state before mplayer vanishes in the bit dust, like switching 
MJ> 'line audio in' off....

huh. if we realy need to cleanup after bad crash then we are facing a
big problem =)
one idea - write a "wrapper" that saves all "states", that should be
restored after exiting, forks mplayer and restores all that when
mplayer exits...
but i think its stupid.
btw, when somebody will write a "player" with g2, he should think
about it =)

-- 
mail="Sergey Pinaev <dfo at antex.ru>"
url="http://`echo $mail | sed 's/.* <\(.*\)>/\1/' | sed 's/@/./'`"



More information about the MPlayer-dev-eng mailing list