[MPlayer-dev-eng] [PATCH] update to new DivX4Linux 5.0.5 API

Andreas Hess jaska at gmx.net
Sun May 25 21:34:42 CEST 2003


On Sun, May 25, 2003 at 03:47:02PM +0200, Alex Beregszaszi wrote:
> > 1) DivX 5.0.5 has 'warmth' as a new postprocessing parameter, shall I
> > add
> >    support for it?
> What is it good for?

It adds temporal noise.

> > 2) In vd_divx4 and vd_odivx the max postprocessing level was 9
> > resulting
> >    in a range of 0..90, but IMHO the correct range should be 0..100.
> >    Is it ok that I've changed it to 10?
> Are you sure the range goes from 0..100 in the older releases?

Yes.

> Btw, there were some c++ like initializers in the control(), fixed it,
> and attached
> the good version of your patch.

The new version won't work because DEC_SET doesn't longer exist in the
new version. And IMHO the original version of my patch should be ok. It
was like this:

<initializer no. 1>
#if ...
<some code>
#else
<initializer no. 2>
<some code>
#endif

So if '#if' isn't true (at compile time), the initializers are C-like at
the beginning.


Andreas



More information about the MPlayer-dev-eng mailing list