[MPlayer-dev-eng] [PATCH] libvo/w32_common.c minor corrections

[Reimar Döffinger]

Hello!

> A better fix would probably be to make the RegisterClass handle the
> class being already registered.

I guess I can do that, but I'm usually of the opinion "If we created it, 
we should free it" althought it is freed by windows when the process 
exits. Maybe best solution would be to do both.


> Well, with all the other vo modules I've tried, if you play something
> in fullscreen, it preserves the aspect ratio when stretching it to the
> size of the screen; I haven't had a chance to test this patch, but won't
> the image now be stretched to the full size of the screen, regardless of
> the aspect ratio?

No (unless I did something very stupid while testing this patch), I used 
-aspect with different values and both vo_directx and vo_gl2 still 
worked the same as before. I know that vo_gl2 calls aspect itself when 
we go into fullscreen mode. Didn't have a look at the directx code.
Another point for doing this is that most drivers will probably need the 
aspect-scaled sizes only at the moment we resize, while the real display 
dimensions might be necessary for more things (although probably not for 
any of the currently available vo for win32) like a OSD that uses the 
whole area (diplaying subtitles below a 16:9 movie) or panscan. This 
would result in lots of "if (vo_fs)" intead of one call to "aspect" in 
the resize function.

Greetings,
   Reimar Döffinger

-- 
Get my GnuPG public key from http://studwww.ira.uka.de/~s_doeffi/key.asc 
or from a keyserver, for example blackhole.pca.dfn.de
Key fingerprint = C61D 16E5 9E2C D10C 8958  38A4 0899 A2B9 06D4 D9C7