[MPlayer-dev-eng] [PATCH] new faad detection in configure

[Diego Biurrun]

James Bilotto writes:
 > On Fri, Nov 07, 2003 at 02:20:49PM +0100, Diego Biurrun wrote:
 > > On Fri, Nov 07, 2003 at 04:02:06AM -0800, James Bilotto wrote:
 > > > On Fri, Nov 07, 2003 at 11:16:46AM +0100, Björn Sandell wrote:
 > > > > On Fri, 7 Nov 2003 02:12:41 +0100
 > > > > Diego Biurrun <diego at biurrun.de> wrote:
 > > > > 
 > > > > > 
 > > > > > I've reworked my faad detection patch a bit, Dominik, James Bilotto,
 > > > > > Björn Sandell please test, this should also fix the version detection.
 > > > > 
 > > > > Nope. Well, it works with --disable-internal-faad:
 > > > 
 > > > the same hear. with some modifications it will thou. patch against cvs
 > > 
 > > > -  if cc_check $_inc_faad $_ld_faad -lm && "$TMPO" >> "$TMPLOG" ; then
 > > > +  if cc_check -I- $_inc_faad $_ld_faad -lm && "$TMPO" >> "$TMPLOG" ; then
 > > 
 > > That is the same change I made in the latest version.  Please try my latest
 > > patch.  Thanks
 > 
 > you missed this part
 > 
 > +# external faad: check if it's really faad2 :)
 > +echocheck "external FAAD2 (AAC) support"
 > +if test "$_faad_external" != no ; then
 > +  _ld_faad='-lfaad'
 > +  _inc_faad="$_inc_extra"
 > 
 > --enable-external-faad will fail without it. can't find the header

Hmmmm

 > +  _inc_faad="$_inc_extra"

This is just a workaround.  I call

  cc_check $_inc_faad $_ld_faad -lm && _faad_external=yes

and the compile call of cc_check is this:

  ( $_cc $CFLAGS $_inc_extra $_ld_static $_ld_extra "$TMPC" -o "$TMPO" "$@" )

So you are just adding $_inc_extra for the second time.  There is
something fishy there.  Please try to debug what happened to your
$_inc_extra, maybe add an

  echo $_inc_extra

just before the cc_check.

Here is another version with some slight changes.

 > thank you for spending time on this

Nice to hear you appreciate it :-)

Diego


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: faad_configure3.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031107/0914dd90/attachment.txt>