[MPlayer-dev-eng] [PATCH] new faad detection in configure

[Diego Biurrun]

James Bilotto writes:
 > On Fri, Nov 07, 2003 at 10:39:59PM +0100, Diego Biurrun wrote:
 > Content-Description: message body text
 > > James Bilotto writes:
 > >  > On Fri, Nov 07, 2003 at 05:41:45PM +0100, Diego Biurrun wrote:
 > [snip]
 > > OK, I'm beginning to see the light, please try the latest incarnation.
 > > Thanks
 > 
 > there is only one problem i see with this
 > 
 > > +_faad_internal=auto
 > > +_faad_external=auto
 > ...
 > > +echocheck "external FAAD2 (AAC) support"
 > > +if test "$_faad_external" != no ; then
 > ...
 > > +  if test "$_faad_external" = auto ; then
 > 
 > the second if dose not make sens, and if you just run configure
 > it will run the internal & external tests and default to external
 > unless there is no external faad, in whitch cass the version check
 > will fail for the internal faad ( can find the header ). i think
 > it should default to internal=yes, external=no

OK, let me explain.  In configure "no" disables a feature, avoiding
autodetection, "yes" enables a feature, avoiding autodetection and
"auto" tries to detect if necessary headers are present or whatever
prerequisites exist, like - in this case - correct library version and
non-buggy gcc.  That's why I'm defaulting both options to auto, there
is autodetection going on after all.

The code will never run both tests:

 > +if test "$_faad_internal" = yes ; then
 > +  _def_faad_internal="#define USE_INTERNAL_FAAD 1"
 > +  _faad_external=no

If the internal test succeeds external faad gets disabled.

Does it work for you now or not?

Diego