[MPlayer-dev-eng] Matroska compile broken from yesterday

[Moritz Bunkus]

Hi,

> I'm not sure I'm reading the source right, but it looks to me like as
> things stand this will be enabled and compiled in if Matroska is
> detected, whether or not FLAC is present (i.e., I see #ifdefs for
> Matroska but none for FLAC in demux_mkv.cpp). Won't that break
> something, if FLAC is not in fact installed? Or am I just being
> programmatically n00bish?

demux_mkv.cpp does not use libFLAC (or the included libmpflac) at
all. It just passes the formattag on to mplayer. If mplayer itself is
not compiled with FLAC support then it ( = mplayer) will just tell you
that it couldn't find a codec for the requested id, and that's all. It's
not the demuxer's job to know which codec mplayer supports. It would be
something different if it actually used functions from libFLAC. But it
doesn't.

-- 
 ==> Ciao, Mosu (Moritz Bunkus)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031117/7d673a08/attachment.pgp>