[MPlayer-dev-eng] Re: [Resend][PATCH] Ueber clean 2.6.x compile fix for vo_{fbdev{2},mga}.c

[Tobias Diedrich]

ismail 'cartman' dönmez wrote:

> diff -u -r1.88 vo_fbdev.c
> --- main/libvo/vo_fbdev.c	8 Nov 2003 00:26:49 -0000	1.88
> +++ main/libvo/vo_fbdev.c	17 Nov 2003 22:03:15 -0000
> @@ -18,7 +18,15 @@
>  #include <sys/mman.h>
>  #include <sys/ioctl.h>
>  #include <sys/kd.h>
> +#include <linux/version.h>
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,70)
> +#define __KERNEL__
> +#include <linux/thread_info.h>
> +#include <linux/list.h>
> +#undef __KERNEL__
> +#endif
>  #include <linux/fb.h>

IMHO it would be better to create a osdep/linuxfb.h wrapper around
linux/fb.h, so the ugly workaround is at least in one central place
instead of being duplicated in 3 files.

Or maybe ship a working linuxfb.h with mplayer...

-- 
Tobias						PGP: http://9ac7e0bc.2ya.com
This mail is made of 100% recycled bits.
np: azumangadaiou: orijinaru saundotorakku Vol.2 01 - 6ninhaitsudemoissho []