[MPlayer-dev-eng] [PATCH] two trivial vbelib fixes

[D Richard Felker III]

On Tue, Nov 25, 2003 at 12:08:34PM +0300, Oleg I. Vdovikin wrote:
> >
> > WTF?!?! mmap to 0x0 is NOT acceptable! This makes it so null pointer
> > dereferences will not cause sig11, but instead overwrite the mmapped
> > /dev/mem!!! Find some other way to make this work without mmapping to
> > 0x0!
>     If you take a closer look to the lrmi stuff you will notice, that's the
> only way to use vm86. It's should have interrupt vectors and bios mmaped to
> zero, otherwise video BIOS calls will not work. The patch submited just
> clears other errors, and keeps other things (such as mmaping) intact.
> 
>     The only way to improve the original code is to include mmap/munmap to
> every vm86 call. BTW, it's possible this memory should also be maped during

Yes, IMO this is the correct way to do it (map/unmap at each call).

> the calls to protected mode extensions. But the patch SHOULD be applied
> anyway, cause it fixes other problems.

Agree.

Rich