[MPlayer-dev-eng] [Patch] libmpdemux/asf_mmst_streaming.c: fixed mms url encoding with multibyte characters

[Wang WenRui]

On Sat, Oct 04, 2003 at 02:54:37PM -0400, D Richard Felker III wrote:
> On Sun, Oct 05, 2003 at 01:06:57AM +0800, Wang WenRui wrote:
> > Hi,
> > 
> >   Current mplayer (mine is mplayer-1.0-pre1cvs20031001) cannot play mms
> >   stream with multibyte characters in the url.
> > 
> >   There is a bug in string_utf16() of libmpdemux/asf_mmst_streaming.c:
> >   the url encoding code is written for single-byte character only. It
> >   just fill a zero byte between every two adjacent bytes of the url
> >   string. This is wrong when the url string contains multi-byte
> >   characters.
> > 
> >   My patch is in the attachment, and has been tested working. It uses
> >   iconv() to convert the url's encoding to utf-16 correctly. So can this
> >   patch be accepted and commit into CVS?
> 
> Shouldn't it be UTF8? UTF16 is pointless and just wastes memory and
> creates endian-dependence issues...
The current mplayer code is using UTF-16, and it is in the specification of the
mms protocol of the SDP Project[1].

Wang

[1] http://sdp.ppona.com/
> 
> Rich
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng