[MPlayer-dev-eng] [PATCH] fix to -geometry switch in xv driver

[Attila Kinali]

On Thu, 9 Oct 2003 09:06:02 +0100
Steve <sgbmplayer at ironmountainsystems.com> wrote:

> 
> Can someone try this and let me know if it works for you, the patch to 
> 1.0pre2 update the xv driver so the -geometry switch works correctly.

Looks fine imho, but the way it's done is not good.
geometry is used in quite a few vo modules, so the patch should
be done in all. On the other hand aspect is used in nearly all
modules. Thus, it would be better to change aspect and geometry,
but this has do be done carefully as it can lead to certain unexpected
behaviour.

BTW: if you would read the manpage you'd see that you have
to use -geometry -noaspect (eventualy with -nozoom if you have
-zoom in your config file).

BTW2: dont use printf in mplayer modules, use mp_msg instead

This aspect/geometry stuff is still on my todo list, i'll
look at it after i finished all the paperwork overhere.


			Attila Kinali

-- 
egp ist vergleichbar mit einem ikea bausatz fuer flugzeugtraeger
			-- reeler in +kaosu