[MPlayer-dev-eng] [PATCH] Multiple fixes for darwin

[Chris Zubrzycki]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday, October 13, 2003, at 07:03  AM, Diego Biurrun wrote:

> On Mon, Oct 13, 2003 at 11:25:18AM +0200, Attila Kinali wrote:
>> On Sun, 12 Oct 2003 09:55:23 -0400
>> Chris Zubrzycki <beren at mac.com> wrote:
>>
>>> I took over maintaining mplayer in fink from Justin, and these are 
>>> the
>>> patches we are currently using for mplayer
>>>
>>> it adds a switch to turn off specific cpu opts (only for darwin atm)
>>> uses hostinfo to determine  the processor of computers running
>>> darwin/ppc
>>> uses the extension .dylib for the xmms lib in darwin
>>> uses -O3 not -O4, 'cause gcc doesn'y have an O4
>>> and fixes the libfame include because there is no ../libfame
>>
>> This patch looks imho ok (though has a lot of codemetics)
>> Ok to commit ?
>
> Isn't this O4 --> O3 thing silly?  I thought it was for forwards
> compatibility with new gcc optimization levels once they are
> implemented.  The Linux kernel is compiled with -O9 for the same
> reason...

I wasn''t sure, but even -O3 is considered pretty evil on os x, and 
sometimes causes problems ;-) we usually use -Os

- -chris zubrzycki
- - --
PGP public key: http://homepage.mac.com/beren/publickey.txt
ID: 0xA2ABC070
Fingerprint: 26B0 BA6B A409 FA83 42B3  1688 FBF9 8232 A2AB C070
========================================================
"Of course, you realize this means war."
- -B. Bunny


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (Darwin)
Comment: Please sign reply-http://www.gnupg.org

iD8DBQE/iqSJ+/mCMqKrwHARArKsAKDfa0EMAU3YtKtcNspeEXCJNQXnqQCgo/va
213lOiWmxSyiT57q9IZTCxw=
=xAg0
-----END PGP SIGNATURE-----