[MPlayer-dev-eng] [PATCH] -saveidx, third time's the charm.

[Diego Biurrun]

Jason Tackaberry writes:
 > Here is an update of the patch incorporating the man page fixes
 > suggested by Diego.

Thanks.

I have some more thoughts about the implementation, though.

 > +.B \-idxfile  <filename>
 > +The file name written to or read from for the INDEX data.  
 > +When specified in conjunction with \-saveidx, MPlayer will force generation 
 > +of the AVI index and write it to filename.  
 > +When \-saveidx is not specified on the command line, MPlayer will read the 
 > +index from filename and use this data for seeking.  

 > +.B \-saveidx
 > +Force rebuilding of INDEX and output to a separate file specified with
 > +\-idxfile.  

This is overly complicated IMHO.  These options need not be
interconnected, but should work independently instead.  If I
understand the description correctly you currently have to do

  mplayer -saveidx -idxfile movie.idx movie.avi

-saveidx should just accept the filename as an option

  mplayer -saveidx movie.idx movie.avi

This is much more logical and consistent and simplifies usage a great
deal.  All other options that write out files work this way.

Sorry for not coming up with this earlier, but please consider my
suggestions anyway.

Diego