[MPlayer-dev-eng] Re: -of mpeg

[D Richard Felker III]

On Fri, Oct 17, 2003 at 10:43:00AM +0200, Attila Kinali wrote:
> Heyo,
> 
> I got this mail yesterday:
> 
> ---schnipp---
> From: Tomi Ollila <tomi.ollila at iki.fi>
> To: kinali at gmx.net
> Cc: too at guru.guru-group.fi
> Reply-To: tomi.ollila at iki.fi
> Subject: muxer_mpeg.c fixes from Andriy N. Gritsenko
> Date: Thu, 16 Oct 2003 18:21:06 +0300
> X-Mailer: VM 7.05 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid
> 
> Hi
> 
> I heard you submit patches to mplayer source tree during weekends...
> 
> The libmpdemux/muxer_mpeg.c has has bugs since introduced to mplayer
> CVS. The original author of that file (Andriy N. Gritsenko) has fixed
> the file now -- patch can be simply obtained by command:
> 
> lynx -dump -width=200 \
>   http://mplayerhq.hu/pipermail/mplayer-dev-eng/2003-October/021184.html \
>   | patch -p1
> 
> 
> Would you consider submitting this patch. It really works now. I sent
> following mail to Andriy about the issue....
> 
> Tomi
> ---schnapp---
> 
> So, can someone please give a comment about this patch ?

I'm curious...is there any way to encode duplicate frames in mpeg
output? Otherwise -of mpeg will always hopelessly break A/V sync, so
it's pointless to fix it and it should just be removed...

Perhaps it would be possible to fix mencoder so it actually encodes
duplicate frames twice (at least optionally)...although I looked at
this once and the code seemed to be too horrible to fix.

> Is it save to commit ?
> 
> [ ] Yes
> [ ] No
> [ ] No yaoi for Gabu!

ROTFL! :)

Rich