[MPlayer-dev-eng] [PATCH] Possible SDL aspect bug, quick workaround

[Fredrik Roubert]

On Sat 18 Oct 20:47 MEST 2003, D Richard Felker III wrote:

> > > Huh? The scaling values generated by aspect() are only used when a
> > > hardware scaler is available, or when -zoom and -vf scale are used. At
> > > least that's the way it's supposed to work.
> >
> > Then we have a bug here.
> >
> > > Maybe vo_sdl is broken and thinks it has an overlay because SDL is
> > > emulating it in software or something stupid...
> >
> > Could you check if there is a bug in the SDL code, or tell me how it is
> > supposed to work so that I can track down the bug?
>
> The problem is that vo_sdl's query_format returns true for YUV
> colorspaces without checking whether hardware overlay support is
> present. This should be checked in the preinit function and stored
> somewhere. It's probably a bit of a mess to fix.
>
> IMO vo_sdl is horrible crap and should be rewritten from scratch, but
> that would be a lot of work...

OK. Then I suggest that my patch is applied:

http://mplayerhq.hu/pipermail/mplayer-dev-eng/2003-May/018669.html

This will prevent vo_dsl from scaling unless -zoom is specified. Later
someone (e.g. myself) could implement the right things in the preinit
function, so that people who actually have a hardware scaler and use SDL
won't have to use -zoom.

Is there anyone who thinks this is a bad idea?

Cheers // Fredrik Roubert

-- 
Möllevångsvägen 6c  |  +46 46 188127
SE-222 40 Lund      |  http://www.df.lth.se/~roubert/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 303 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031018/92ee92a1/attachment.pgp>