[MPlayer-dev-eng] [PATCH] Forced subtitles[corrected]
Diego Biurrun
diego at biurrun.de
Mon Oct 20 02:22:15 CEST 2003
Michael Niedermayer writes:
> On Thursday 02 October 2003 02:18, Diego Biurrun wrote:
> > Alex Beregszaszi writes:
> > > > Any other suggestions?
> > >
> > > Never ever use underscores in config options!
> >
> > Shall we change these then:
> >
> > cfg-common.h: {"fribidi_charset", &fribidi_charset, CONF_TYPE_STRING, 0, 0,
> > 0, NULL}, cfg-common.h: {"flip_hebrew", &flip_hebrew, CONF_TYPE_FLAG, 0, 0,
> > 1, NULL}, cfg-common.h: {"noflip_hebrew", &flip_hebrew, CONF_TYPE_FLAG, 0,
> > 1, 0, NULL},
> >
> > cfg-mplayer.h: {"stop_xscreensaver", &stop_xscreensaver, CONF_TYPE_FLAG, 0,
> > 0, 1, NULL}, cfg-mplayer.h: {"nostop_xscreensaver", &stop_xscreensaver,
> > CONF_TYPE_FLAG, 0, 1, 0, NULL},
> >
> > Patch attached.
> btw, a few lavc options use underscores too, so they should be changed too if
> we change _ -> -
Hmm, just had another look, all lavcopts use _, so they are at least
consistent among themselves. Shall we change all of them to - also?
Diego
More information about the MPlayer-dev-eng
mailing list