[MPlayer-dev-eng] [PATCH] codec-cfg.c docs path

Diego Biurrun diego at biurrun.de
Mon Oct 20 13:49:51 CEST 2003


Gabucino writes:
 > Diego Biurrun wrote:
 > > -        f2=fopen("DOCS/en/codecs-status.html","wb"); if(!f2) exit(1);
 > > +        f2=fopen("DOCS/HTML/en/codecs-status.html","wb"); if(!f2) exit(1);
 > > codec-cfg will silently fail if the DOCS/HTML/en/ directory does not
 > > exist.  Is that a problem?  Or does everybody using that tool know
 > > what he/she is doing?
 > codec-cfg is miserably braindamaged, lacks any and every type of exit error
 > codes, silently miscompiles if something is broken. You better avoid it if
 > possible.

Yes, it could at least exit with an error message or just create the
directory on demand.

 > What does it use the path above for?

When called directly, it generates and writes codecs-status.html to
DOCS/en/, which is an empty and obsolete directory (cvs update should
remove it when run with -P).  It should write to DOCS/HTML/en/
instead, but this directory is only present if you have generated docs
in DOCS/HTML/en/, DOCS/HTML/en/ is not present in a vanilla CVS
checkout.

Diego




More information about the MPlayer-dev-eng mailing list