[MPlayer-dev-eng] [PATCH] Endpos for Mplayer.

[Diego Biurrun]

Konstantinos Karydas writes:
 > > Konstantinos Karydas writes:
 > >  > I hope it all makes sense. I have changed only 3 files:
 > >  > cfg-common.h, cfg-mencoder.h and of course mplayer.c and I indent
 > >  > all my changes with "kkar". I am willing to answer you any
 > >  > questions that could help at anything.  Please help if you can. I
 > >  > would be grateful.
 > >
 > > Please read DOCS/tech/patches.txt.
 > 
 > Instead of telling me to read the DOCS all the time (which BTW I did but I
 > can't find anything wrong in whatever I did!) could you please tell me what
 > I am doing wrong with your rules??? As I said I did my best to follow your
 > rules and I don't really have much time for mplayer develpoment. Thank you.

You should send a unified diff instead of complete files as it says in
DOCS/tech/patches.txt:

  2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). Unified diffs
     can easily be applied with 'patch'. This is much harder with
     other diff types.

This is not meant as harassment, but complete files become useless the
moment anybody commits to them, which happens very frequently.  We
need to see the changes to make reviews.  Diffs show the changes
directly.

I added some words about this to DOCS/tech/patches.txt.

Diego