[MPlayer-dev-eng] [PATCH] Endpos for Mplayer.

[Jason Tackaberry]

On Mon, 2003-10-20 at 09:21, Konstantinos Karydas wrote:
> Instead of telling me to read the DOCS all the time (which BTW I did but I
> can't find anything wrong in whatever I did!) could you please tell me what
> I am doing wrong with your rules??? As I said I did my best to follow your
> rules and I don't really have much time for mplayer develpoment. Thank you.

Hi Kostas,

I don't want to be crass, but are you reading the same document as I am?

>From DOCS/tech/patches.txt:

     1. Always make patches for the CVS version. The README describes
        how to check out CVS and daily CVS snapshots are available from
        our download page. We do not accept patches for releases or
        outdated CVS versions.
     2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). Unified
        diffs can easily be applied with 'patch'. This is much harder
        with other diff types.
     3. ... the following rules go on to talk about _patches_.

I'm not an MPlayer core developer and can't speak for them, but you can
imagine they get dozens of patches a week and are fairly backlogged (I
have 2 in the queue and that's just one person).  As a contributer, it's
your job to make it easy and convenient for the core developers to
review and comment on your patch.

Sending them a tar.bz2 containing the entire files from an unknown
version (release?  CVS?  What date?) means they have to extract your
tarball, diff it against their cvs tree, wade through all the irrelevant
changes (since a lot will have changed other than your modifications),
and _then_ review and critique your patch.

Unless your submission happens to scratch a personal itch of a core
developer, I think there's just no way it will get looked at, because
there are always a good number of patches in the queue that are
submitted in a way that is more convenient for them to review.

Cheers,
Jason.

-- 
Jason Tackaberry  ::  tack at auc.ca  :: 705-949-2301 x330 
Academic Computing Support Specialist
Information Technology Services
Algoma University College  ::  www.auc.ca