[MPlayer-dev-eng] [PATCH] vf_eq2 default parameter fix

[D Richard Felker III]

On Tue, Oct 28, 2003 at 12:56:59PM +0100, Arpi wrote:
> Hi,
> 
> >  > > 
> >  > > The best solution would be brightness:contrast:gamma IMHO in order to
> >  > > be consistent with -vf eq.  If you only want to specify gamma you will
> >  > > have to use -vf eq2=::XX, but that is only a small inconvenience for
> >  > > you resulting in a big gain in usability and consistence for the rest,
> >  > > so please consider making that change.
> >  > 
> >  > OK, here it is. I'm still not convinced, but your wish is my
> >  > command ;-)
> >  > 
> >  > Besides, there were some changes to vf_eq2 lately and the old
> >  > patch doesn't apply cleanly anymore, so I had to redo it
> >  > anyway.
> > 
> > If nobody objects I am going to commit this in the next days.
> 
> I do object, and i've already explained why in a different branch of this
> thread.
> 
> vf_eq2 is mostly used for gamma settings, and so its normal and natural
> that gamma is the first (and recommended) parameter.
> others (contrast brightness etc) are rarely used with this filter,
> a sthere are much more faster and efficient filters for that (vf_eq and
> scale, but most users don't need them as vo driver can do it as well)

Also it could break existing scripts... IMO we can wait to sanitize
the filters until we overhaul them all for g2; no one will expect g2
syntax to be identical to g2 so there's no harm then.

Rich