[MPlayer-dev-eng] [PATCH] 2d denoiser, second edition

[Corey Hickey]

Arpi wrote:
> Hi,
> 
> 
>>Michael A Baikov wrote:
>>
>>>Ok here goes next version of 2d denoiser filter. Fixed some bugs.
>>>                                                                                               
>>>To: Michael Niedermayer
>>> Yes, algorithm looks like sab, but because of those additions, it differ.
>>>Moreover, I want to add even more intresting additions to improve quality
>>>(dualpass filtrating and multipass selfadaptation filtrating). So, let sab
>>>stays as sab, and hqdnsm stays as hqdnsm.
>>>                                                                                               
>>> Thanks for bughunting.
>>>
>>
>>I just applied your patch to current CVS, and make died with the errors
>>shown below. If you want any more information, please tell me.
>>
>>-Corey
>>
>>gcc-3.2 -c -W -Wall -Wno-unused-parameter -O2 -march=athlon-4 
>>-mcpu=athlon-4 -g3  -D_REENTRANT -D_LARGEFILE_SOURCE 
>>-D_FILE_OFFSET_BITS=64 -I. -Inative -I.. -I../libmpdemux -I../loader 
>>-I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include 
>>-D_GNU_SOURCE -o vf_hqdnsm.o vf_hqdnsm.c
> 
> 
> the good old gcc 3.2, with unsupported CFLAGS...
> 

I didn't set the CFLAGS myself (at least, not intentionally). I just did
this:
$ export DEB_BUILD_OPTIONS="--disable-runtime-cpudetection \
--enable-linux-devfs --enable-gui --enable-largefiles --enable-joystick\
  --enable-menu --enable-qtx --with-reallibdir=/usr/lib/win32 \
--cc=gcc-3.2 --enable-live --with-livelibdir=/usr/local/lib/live \
--enable-xvmc --enable-debug=3"

$ fakeroot debian/rules binary

That's how I've built mplayer for a long time.

> didn't you read what ./configure prints? :
>

It never prints that message for me. Neither if I use debian/rules
or just ./configure. Avoiding the debian script for now, I just tried
gcc 2.95, 3.2.3, and 3.3.1.

./configure --cc=gcc-2.95 && make  --  fails
./configure --cc=gcc-3.2 && make   --  succeeds
./configure --cc=gcc-3.3 && make   --  fails

For comparison, here's the output of gcc-2.95:
gcc-2.95 -c -O4 -march=i686 -mcpu=i686 -pipe -ffast-math 
-fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE 
-D_FILE_OFFSET_BITS=64 -I. -Inative -I.. -I../libmpdemux -I../loader 
-D_GNU_SOURCE -o vf_hqdnsm.o vf_hqdnsm.c
vf_hqdnsm.c: In function `scanMMX2':
vf_hqdnsm.c:285: parse error before `['
make[1]: *** [vf_hqdnsm.o] Error 1
make[1]: Leaving directory `/usr/local/src/mplayer/main/libmpcodecs'
make: *** [libmpcodecs/libmpcodecs.a] Error 2


-Corey