[MPlayer-dev-eng] [PATCH] New audio filter: export (now Ok, with docs)

[Gustavo Sverzut Barbieri]

 --- Diego Biurrun <diego at biurrun.de> escreveu: > Gustavo Sverzut
Barbieri writes:
>  >    Also, the patch applies to DOCS/en/mplayer.1 and
>  > DOCS/xml/en/audio.xml
> 
> Thanks, here are some comments.
> 
>  > --- DOCS/en/mplayer.1	5 Sep 2003 14:18:03 -0000	1.435
>  > +++ DOCS/en/mplayer.1	14 Sep 2003 19:39:22 -0000
>  > @@ -1982,6 +1982,13 @@ d: delay time in ms for the rear speaker
>  >  Delays the sound output.
>  >  Specify the delay separately for each channel in milliseconds
> (floating point
>  >  number between 0 and 1000).
>  > +.IPs export[=file[:nsamples]]
>  > +Exports the incomming signal to other processes using memory
> mapping (mmap())
> 
> incoming should only have one 'n' (that typo is in the .c file, also)

'm' you mean? incoming, right?
Sorry about that, it's everywhere because just copied and pasted it.


>  > +.RSss
>  > +file: file to map data to. The default is
> ~/.mplayer/mplayer\-af_export
>  > +.br
>  > +nsamples: number of samples per channel. The default is 512.
>  > +.REss
> 
> 
>  > --- DOCS/xml/en/audio.xml	24 May 2003 21:24:50 -0000	1.4
>  > +++ DOCS/xml/en/audio.xml	14 Sep 2003 19:39:51 -0000
>  > @@ -942,6 +942,39 @@ would add surround sound decoding with 1
>  >  rear speakers.
>  >  </para>
>  >  </sect4>
>  > +
>  > +<sect4 id="af_export">
>  > +<title>Audio Exporter</title>
>  > +<para>
>  > +This audio filter exports the incomming signal to other processes
> 
> see above
> 
>  > +using memory mapping (mmap()). Memory mapped area contains a
> header:
>  > +<literal>int nch</literal> (number of channels), 
>  > +<literal>int size</literal> (buffer size), 
>  > +<literal>unsigned long long counter</literal> (used to keep sync,
> it's
>  > + updated everytime new data is exported). The rest is payload
> (non-interleaved) 16bit data.
> 
> "everytime" should be two words, "every time"

Fixed too.

 
>  > +</para>
>  > +
>  > +<variablelist>
>  > +<varlistentry>
>  > +<term><option>mmaped_file</option></term>
> 
> 'mmapped_file' should have two 'p' and it should probably be just
> plain
> 'file' like in the man page, or it should also be 'mmapped_file' in
> the man page.  This should be consistent.

Ok. I choosed 'mmapped_file' so it make clear it's mmap() and not plain
file (Ie, raw data)

 
>  > +<listitem><para>
>  > +the file you want this filter to export to. The default is to map
> to 
>  > +<literal>~/.mplayer/mplayer-af_export</literal>.
>  > +</para></listitem>
> 
> This is wrong,
> 
> </varlistentry>
> <varlistentry>
> 
> is missing.  The build will fail as is.

Ok, I just copy&paste the item before, which have only one entry, then
the mistake.

Thanks,

Gustavo

_______________________________________________________________________
Desafio AntiZona: participe do jogo de perguntas e respostas que vai
dar um Renault Clio, computadores, câmeras digitais, videogames e muito
mais! www.cade.com.br/antizona
-------------- next part --------------
A non-text attachment was scrubbed...
Name: af_export.patch
Type: application/octet-stream
Size: 4419 bytes
Desc: af_export.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030915/2d93f2ee/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: af_export.c
Type: text/x-csrc
Size: 7006 bytes
Desc: af_export.c
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030915/2d93f2ee/attachment.c>