[MPlayer-dev-eng] [PATCH] (SuSE) multiple patches - please review!

[Michael Niedermayer]

Hi

On Friday 26 September 2003 21:10, Alex Beregszaszi wrote:
> Hi,
>
> > > Additionally, these are the patches SuSE was applying on MPlayer. I
> > > think we should apply at least a part of them (most are portability
> > > fixes).
> >
> > agree
>
> checked it, most of the parts are already commited.
>
> The asm stuff is imho only cosmetical.
hmm, if a variable is accessed only within an asm like in
asm(
 " ... VAR ..."
);
instead of 
asm(
: "r" (VAR) 
);
then the compiler cannot know about it as its just passing the stuff to the 
assembler and the compiler may simply omit the variable completly, the 
attribute(used) avoids that, but u r right that it is just cosmetics, as 
compilation does work all variables are probably either accessed from c or 
cleanly passed to the asm code ...

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en