[MPlayer-dev-eng] cvs-howto.txt

[Reimar Döffinger]

Hi,

> editor should mean here $EDITOR, dunno what cvs does if it is not set.
> Also be aware that a few "modern" distros think vi is evil and dont
> install it anymore.

If it's not set cvs uses vi. So those "modern" distros either hacked cvs 
or broke it...


> One can never overtest things. Changes should be always tested as much
> as possible to cover all possible bugs one can think off. Changing stuff
> with the attitude of "if it breaks something, someone will complain"
> isnt exactly what we want.

Given the amount of reaction I get when I say: "Could somebody please 
test", which is none at all, compared to the one I get when I simply 
apply...
I have to say you're right that the attitude isn't what we want but 
sometimes it's hard to do it differently, especially if you don't have 
the hardware for which the fix is.

>>    * If you find changes within a diff block that you don't want to commit
>>      you can delete them if they are the only changes ranging from the
>>      @@ -x,y +x,y @@ until the line before the next @@ -x,y +x,y @@. You
>>      _cannot_ remove single lines after a @@ -x,y +x,y @@ because that will
>>      break the patch!.
> 
> You can, you just have to adjust the numbers (yes, i do that quite
> often)

Well, you can add any explanation then ;-). I did it once but decided it 
is easier to edit the source file...

>>4. It's almost time for the final step, committing the changes. But first you
>>  MUST make sure your changes compile without breaking anything and that it
>>  follows the Policy mentioned in section 2. (Read it until your eyes are
>>  bleeding if you want to keep CVS access!)
>>  Don't worry about object files etc that will be created in your "main" dir,
>>  they won't  be sent to CVS on a commit, you must use the add command to add
>>  new files (discuss it on dev-eng before adding new files!).
>>  Now to make sure your additions follow policy do the following on every file
>>  you will commit:
>>
>>    cvs -z3 diff -u <filename> > <filename.d>
> 
> a `cvs diff -u .` in main/ should be performed instead so any
> unintentional change is also captured.
> btw: cvs diff -u |less works too

cvs diff -u . isn't exactly neccessary if you do only cvs ci <filename>.

Greetings,
Reimar Döffinger