[MPlayer-dev-eng] [PATCH] Complete libmpdvdkit cruft removal

[eviv bulgroz]

Diego Biurrun wrote:

>eviv bulgroz writes:
>  
>
>>Here is a patch to complete the libmpdvdkit/libmpdvdkit2 cruft removal.
>>    
>>
>
>Rejected.
>
>I don't like this patch.  The tests are kept there in case somebody
>adds libmpdvkit (the first version) to his tree for whatever reason,
>although I have no idea if it would still work and I doubt it is
>useful.
>
I doubt it will be usefull too.
http://mplayerhq.hu/pipermail/mplayer-dev-eng/2003-October/021847.html
http://mplayerhq.hu/pipermail/mplayer-dev-eng/2003-October/021928.html
http://mplayerhq.hu/pipermail/mplayer-dev-eng/2003-October/021930.html
http://mplayerhq.hu/pipermail/mplayer-dev-eng/2003-November/022012.html
We came up short of cleaning it completely, at least we could remove 
reference to libmpdvdkit since it has disappeared from the cvs tree.

>  Still, renaming everything to mpdvdkit when the directory is
>called libmpdvdkit2 is just obfuscation IMHO.  So removing the old
>tests/variables might be OK as it's basically cruft, but renaming is
>not.
>
Initially libmpdvdkit2/ was created by Arpi to test it along libmpdvdkit
http://mplayerhq.hu/pipermail/mplayer-dev-eng/2002-August/010199.html
and later on libmpdvdkit/ was removed from cvs instead of being patched!!
So you're right without being able now to rename the directory, it 
doesn't make much sense to rename

Here is another patch with less renaming ...
Eviv

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libmpdvdkit_cruft.diff
Type: text/x-patch
Size: 4907 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040801/7ff94aa6/attachment.bin>