[MPlayer-dev-eng] [PATCH][BUG] Incorrect memleak fix code in input/input.c might cause incorrect free

[Shachar Raindel]

On Tue, 3 Aug 2004 00:35:56 +0200, Alexander Strasser <eclipse7 at gmx.net> wrote:
> On Mon, Aug 02, 2004 at 06:43:33PM +0200, Alexander Strasser wrote:
> > On Mon, Aug 02, 2004 at 07:24:21PM +0300, Shachar Raindel wrote:
> > > The patch this time is much more clean. I think I found the most
> > > elegant solution - free file only if it is not the same as
> > > config_file, and remove the weird stuff in the if added by alex. This
> > > should do the trick, without any unneeded memory allocations (and BTW,
> > > I was wrong about the ternary operator - only one of the expressions
> > > is evaluate, so when one writes "a?b:c" than a is evaluated, and
> > > afterward either b or c, but not both).
> > Seems like a good and correct solution to me.
> > I will commit it tonight if nobody objects.
> Strangely your patch didn't apply, though that's no big problem for
> this tiny patch...
> But i got some doubts as i looked at the situation again.
> So this is delayed until tommorow.

I manually removed one added line of white-space from the patch, and
maybe even though emacs try to keep the counters correct, it messed
them up.... Anyway, it shouldn't be a problem to apply it manualy.
Yell if you want me to resend a fixed version....


     Cheers,
     Shachar