[MPlayer-dev-eng] [PATCH] JPEG video output to multiple subdirectories v2

[Ivo]

On Sunday 01 August 2004 07:08, Attila Kinali wrote:
> And more comments to come :)

And thanks for that! I have to get used to the conventions of this (huge) 
project.

> [snip - loads of comments]

I have changed my patch to accommodate to all your comments and suggestions 
and I also:

- Moved the creation and/or testing of outdir from draw_frame to config. It 
seems to me that's a better place to do such things (when the vo_jpeg 
module is initialized).

- Made sure maxfiles is always equal or larger than 1 (zero or negative 
numbers don't make any sense).

I wasn't quite sure if it's okay to use perror, but since there are other 
modules that use it, I used it too. Let me know if there's a better way. It 
could probably be done with mp_msg and sys_errlist, but I didn't see any 
use of that in the rest of the code.

> Otherwise i would say it looks ok, but i havent read the code of vo_jpeg
> itself, so i cannot say for sure.

There's not much more in vo_jpeg. Just some code that calls libjpeg to 
compress the current frame and write it to a file.

Updated patch is attached. Patched against cvs of:

Wed Aug  4 03:34:11 CEST 2004

Looking forward to more comments or a "Committed" message :-))

Later!
--Ivo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_jpeg_patch_v3
Type: text/x-diff
Size: 7904 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040804/80e4b704/attachment.diff>