[MPlayer-dev-eng] [PATCH] configure LIVE autodetection

[Torinthiel]

On Thu, Aug 05, 2004 at 12:42:24AM +0200, Diego Biurrun wrote:
> 
> Torinthiel writes:
> > I have copied LIVE version test from libmpdemux/demux_rtp_internal.h to
> > ./configure script. Could someone look at it and say if it is ok to
> > apply? Especially there was a #undef STREAM_SEEK just before #include
> > in demux_rtp_internal.h, and however I don't think it has any effect on
> > test, I'm not sure about it.
> 
> That #undef was a MinGW compilation fix, just look at the CVS log.
> Anyway, it seems to work without it on MinGW.
> 
> In principle moving this test here is a great idea, configure should
> detect if it is the correct library version, compilation breaking
> every once in a while because the lib is outdated is annoying.  But
> LIVE.COM is a bit special in that it does not usually get installed in
> standard locations, so you have to use the --with-livelibdir option.
> This option sets live=yes, though, so the test is never run...

So? Why not remove _live change from --with-livelibdir processing? This
way user can still force his own opinion (passing --enable-live and
--with-livelibdir) but if he only passes --with-livelibdir then we check
if the version is correct.

And while we're at it- if this gets applied should we also remove test
from demux_rtp_internal.h? Or leave double test in case somebody forces
live with wrong version?
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040805/883e064b/attachment.pgp>