[MPlayer-dev-eng] [PATCH] FreeBSD DVD Fix

[Jan Knutar]

On Saturday 07 August 2004 07:45, rcooley wrote:

> This is quite interesting...  First of all, NONE of the FreeBSD patches
> I sent were applied.  That should tell you something.

Several of them ripped out portable CPU detection things and replaced them with stuff
that only works on *BSD. Not something you can really commit.

Then there was a streaming patch which was already in mplayer, some random
cosmetics(?), and one that I'm still intersted in regarding ARTS.

I'm inclined to believe that it's actually a bug in artsc that they're working around,
but I do get the same crashes without the fix... Mplayer will segfault upon attempting
to unint arts ao, if arts init had failed. Problem is, it doesnt segfault on closing the non-
existant stream, but segfaults on arts_free(), which is supposed to clean up space
artsc has allocated itself.
The FreeBSD patch is to simply comment out the offending line and never have arts
clean up after itself. Not necessarily completely evil, but I guess this would potentially
leak some memory in gmplayer which, I think, can go through several init/uninit cycles...

To sum it up, ignore the above insane ranting and investigate ao_arts :-)