[MPlayer-dev-eng] [PATCH] loader fixes

Torinthiel torinthiel at megapolis.pl
Mon Aug 9 10:11:29 CEST 2004


On Sat, Jul 31, 2004 at 08:41:39PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> Hi.
> A round of issues and proposed fixes. This is a follow-up for
> http://mplayerhq.hu/pipermail/mplayer-dev-eng/2004-April/thread.html#25088
> and
> http://mplayerhq.hu/pipermail/mplayer-dev-eng/2004-April/thread.html#25156
> and
> http://mplayerhq.hu/pipermail/mplayer-dev-eng/2004-April/thread.html#25167
> 
> You're welcome to yell.
[cut]

> Problem:
> MPEGLAYER3WAVEFORMAT struct defined twice (in loader/wine/mmreg.h
> and our libmpdemux/ms_hdr.h). It's part of Alex's somewhat failed attempt
> to implement my solution for platform-independent avi format definitions.
> 
> Solution:
> Surround both with:
> #ifndef _MPEGLAYER3WAVEFORMAT_ 
> #define _MPEGLAYER3WAVEFORMAT_ 
> [...]
> #endif /* _MPEGLAYER3WAVEFORMAT_ */

I have yelled at it on commit (at -cvslog), but got ignored. Hell, maybe
because it was without a patch. But patch was on previous commit, that
introduced double definition.
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040809/bbba1111/attachment.pgp>


More information about the MPlayer-dev-eng mailing list