[MPlayer-dev-eng] [PATCH] fixing rgb24toyv12

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Aug 10 22:28:04 CEST 2004


Hi,
> the mmx code works with more then 2 pixels at a time, so it will write over 
> the end, thats why the last line(s) are done with the c code even if width%
> 2==0

Ok thanks, I think I get the idea. Assembler code confuses me ;-)

>>Anyway, do you agree that the old version could segfault when width /
>>height is not divisible by 2, and thus the two line above make sense
>>(although they're ugly)?
> 
> yes, but i am not happy about the width/height hack

I'm also not happy about it. I applied the part changing width to 
chromWidth, but nothing else.
I leave finding a solution to the rest to everyone else while I'm on 
holiday ;-)

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list