[MPlayer-dev-eng] [PATCH] tivo vstream

[Joey Parrish]

On Thu, Aug 12, 2004 at 01:08:24PM +0200, Diego Biurrun wrote:
> > +  --disable-vstream      build with TiVo vstream [enable]
> 
> I would suggest setting it to disabled by default.  Only very few
> people have a TiVo.

I believe that it doesn't actually do anything but increase
executable size unless you use tivo:// URL.  So I disagree.
Is there another reason to disable?

> > +#if defined(__CYGWIN__)
> > +typedef unsigned long long loff_t;
> > +#endif
> > +
> > +#if defined(SYS_DARWIN)
> > +typedef unsigned long long loff_t;
> > +#endif
> 
> This is ugly, why not
> 
>   #if defined(__CYGWIN__) || defined(SYS_DARWIN)
>   typedef unsigned long long loff_t;
>   #endif

Because this isn't my code.  :)  Ask tivo-mplayer folks.
But I'll change that before commit (if commit is okay.)

--Joey

-- 
"Ours is not to question why, 'cause if we did,
  our heads would explode." --Megan