[MPlayer-dev-eng] [PATCH] FreeBSD DVD Fix

[Bernd Ernesti]

On Thu, Aug 19, 2004 at 06:34:19PM +0200, Diego Biurrun wrote:
> jb13 at gomerbud.com writes:
> > On Wed, Aug 11, 2004 at 10:27:59AM +0200, Diego Biurrun wrote:
> > > 
> > > All of these patches need some explanation IMHO, so NetBSD people,
> > > please stand up.
> > 

[configure -Wl patch]

> > this is for proper linking on netbsd, for an explanation why see
> > 
> > http://www.NetBSD.org/Documentation/elf.html
> 
> OK, it seems like the commented out version comes from a NetBSD
> portability patch.  A real portable solution would have to choose
> intelligently between the two at runtime, though.

I know and I was too lazy too make one.

> > -  pfamily=`$_cpuinfo | grep 'cpu family' | cut -d ':' -f 2 | cut -d ' ' -f 2 | 
> > head -1`
> > +  pfamily=`$_cpuinfo | grep -i 'cpu family' | cut -d ':' -f 2 | cut -d ' ' -f 2
> >  | head -1`
> > 
> > from grep(1)
> >   -i, --ignore-case
> >      Ignore case distinctions in  both  the  PATTERN  and  the  input files.
> 
> Sure, but why is that needed?

Because at one point we changed the /proc/cpuinfo in NetBSD-current to return
a different case for the cpu family, something like 'Cpu family', don't remeber
now, but that was changed back to 'cpu family'.
IMHO that patch should also be removed from the NetBSD pkgsrc.

Bernd