[MPlayer-dev-eng] [PATCH] tivo vstream with DOCS

[Joey Parrish]

On Sun, Aug 22, 2004 at 03:44:51PM +0200, César Ramos wrote:
> Any advance?

Yes, I've managed to find the place in vstream where connections are
opened and replace it with the call to equivalent function in mplayer's
libmpdemux/network.c ...

But I've decided after much much much review of the vstream code that I
no longer want to include it in MPlayer.

There is a lot of code in vstream that has nothing to do with being a
vstream client.  Tons of it.  I made a tree of function calls and found
all the calls that actually do something.  The result is that I was able
to remove some 20+ kb of unused code.  What's left still has more than a
half-dozen calls to exit(1).  In many places, instead of returning
information error status and having caller check for error, vstream
calls exit when an error is found.  Before I could include vstream lib
in MPlayer, I'd have to fix all of this.

I still think vstream client is a really useful feature for folks with a
tivo, so I will try to do this instead:

I will suggest to the vstream author that I work with him in
restructuring the code and making vstream a proper library.  Then the
client code in vstream can be linked to from an optional MPlayer module.
Thus the people who want it can have this feature, MPlayer doesn't see
yet more bloat, and the library itself can take on a better, more useful
life.

So, just don't worry about it for now.  Anyone terribly interested in
vstream client abilities can either:
1) get source from tivo-mplayer.sf.net
2) get cygwin binaries from tivo-mplayer.sf.net
3) get my soon-to-be-released cygwin package from armory.nicewarrior.org
  which will include the same client code (with an improvement or two).

Sorry for wasting everyone's time with this huge thread.

I'll be back,
--Joey

-- 
"The greatest thing you'll ever learn
is just to love and be loved in return." -- Darth Vader