[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc.), second patches

[The Wanderer]

Attila Kinali wrote:

> On Wed, Aug 18, 2004 at 04:57:58PM -0400, The Wanderer wrote:
> 
>> A little more work on the conversion. These patches cover
>> mplayer.c, and assume that the syntax-change patch from the
>> previous set has not been applied but that the others have.

>> -  if(how) mp_msg(MSGT_CPLAYER,MSGL_INFO,MSGTR_Exiting,mp_gettext(how));
>> -  mp_msg(MSGT_CPLAYER,MSGL_DBG2,"max framesize was %d bytes\n",max_framesize);
>> +  if(how) mp_msg(MSGT_CPLAYER,MSGL_INFO,MSGTR_ExitingHow,mp_gettext(how));
>> +  mp_msg(MSGT_CPLAYER,MSGL_DBG2,MaxFramesizeWas,max_framesize);
> 
> Please dont add DBG2+ to the help-*.h, they are of no use for the
> casual user but create unnecessary work for the translators as these
> messages should always be printed in english.

Acknowledged; will change, and resend (probably) shortly.

I could argue against this, as it assumes that would-be developers will
always speak/read English (at least fluently and possibly as primary
language), but in practice - especially given the rules of the
development list - I can see that it works out.

>>     case MP_CMD_EDL_MARK:
>>       if( edl_fd ) {
>> 	float v = sh_video->pts;
>>+	// how to do this with mp_msg? define MSGT_EDL?
>> 	fprintf( edl_fd, "%f %f %d\n", v-2, v, 0 );
> 
> Not at all, that's for edl output, which isnt exactly translatable :)

Will remove that part, then, and check for other similar issues; I'm not
even sure why I added that comment in the first place, since fprintf
doesn't use stdout and hence doesn't have a problem.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.