[MPlayer-dev-eng] [PATCH] automatically insert vf_expand for displaying OSD

[Attila Kinali]

On Sun, Aug 22, 2004 at 09:41:15PM -0500, Joey Parrish wrote:
> On Sat, Aug 21, 2004 at 10:42:24AM +0900, Attila Kinali wrote:
> > I dont know whether this is a good idea. expand will slowdown
> > playback considerably. On the other hand, the user requested to have
> > subtitles...
> 
> It inserts vf_expand when the vo doesn't support osd.  So, it slows
> down playback for the vo's that don't support osd, no matter what.
> These vo's are (according to grep):
> 
> > vo_3dfx.c
> > vo_bl.c
> > vo_cvidix.c
> > vo_dxr2.c
> > vo_dxr3.c
> > vo_fbdev.c
> > vo_fbdev2.c
> > vo_gif89a.c
> > vo_gl.c
> > vo_jpeg.c
> > vo_md5.c
> > vo_mga.c
> > vo_mpegpes.c
> > vo_null.c
> > vo_pgm.c
> > vo_png.c
> > vo_syncfb.c
> > vo_tdfx_vid.c
> > vo_tga.c
> > vo_winvidix.c
> > vo_xmga.c
> > vo_xover.c
> > vo_xvidix.c
> > vo_zr.c
> > vo_zr2.c

I dont think this is true, at least mga, xmga, xvidix can handle
subs by themselfs.

> So, if vf_expand is that slow, then I retract my vote for commit.

It's not that slow, i used it on my laptop (700MHz PIII) w/o
conciderable speed los. I just care more about the slow system who are
already at the limit with just playing the file. IMHO it's a policy
decission: Shall filters that may slowdown playback be added
automagicaly or not.

IMHO this is a no, no matter how much/little it slows down.

			Attila Kinali