[MPlayer-dev-eng] Re: [PATCH] vo_xv: fix black screen in fullscreen (2)

[Alexander Strasser]

On Mon, Aug 23, 2004 at 08:48:04PM +0200, Marko Macek wrote:
> Attila Kinali wrote:
> 
> >
> >Thanks for the patch. I'm currently waiting for a comment from
> >beastd (the current x11/xv maintainer) as he said he'll work on it.
> > 
> >
> Here's a new patch.
> 
> Compared to previous one it fixes:
>    - off-by-one in XvShmPutImage (Me and beastd both wonder why it was 
> there)
I'll remove this separately as it is even without your patch more logical
to not draw height-1 at fullscreen.

> -                      (vo_fs ? vo_dheight - 1 : vo_dheight) + vo_panscan_y,
> +                      (vo_fs ? vo_dheight : vo_dheight) + vo_panscan_y,

> -                   (vo_fs ? vo_dheight - 1 : vo_dheight) + vo_panscan_y);
> +                   (vo_fs ? vo_dheight : vo_dheight) + vo_panscan_y);

And I also think that the ternary operator isn't needed anymore here ;)

  Alex (beastd)