[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc.) first patches, second try

[The Wanderer]

Diego Biurrun wrote:

> The Wanderer writes:
> 
>> As requested, here are the patches again, essentially identical
>> except for revision dates (and a few line-number updates) to the
>> versions initially posted.
> 
> Since Attila reviewed and OKed these patches I'll apply them if you 
> make a few small modifications as outlined below.
> 
>> +#define MSGTR_CBRPCMAudioSelected "CBR PCM audio selected\n"
> 
> Here and below you should end complete sentences in a period.

Very well; my rule so far has been to faithfully duplicate the string
moved, with the idea that there should be no visible difference between
output before and after the patch, but if you want me to make
corrections like this in the process I can certainly do so.

Aside from obvious typos/spelling errors, any guidelines as to what
should or should not be changed like this? Given free rein, I'd probably
be as likely as not to make countless nitpicky changes...

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.