[MPlayer-dev-eng] [PATCH] vo xv change

[Alexander Strasser]

Hi,
we recently detected ( see Message-ID: <412A3BE4.8050804 at gmx.net> )
a bogus subtraction in vo xv.
In flip_page XvPutImage is called with height-1 when in fullscreen.

Nobody knows why it is there and it seems not only unnecessary but
even wrong. If somebody knows why it was added, please speak...
Our only guess was a weird graphics driver bug workaround.

I attached a patch which does the change i want to make very soon.
So vo xv users please test and report results/problems.

Or test next time with `cvs up' ;)

  Alex (beastd)
-------------- next part --------------
Index: libvo/vo_xv.c
===================================================================
RCS file: /cvsroot/mplayer/main/libvo/vo_xv.c,v
retrieving revision 1.154
diff -u -r1.154 vo_xv.c
--- libvo/vo_xv.c	20 Aug 2004 09:41:13 -0000	1.154
+++ libvo/vo_xv.c	31 Aug 2004 02:04:31 -0000
@@ -579,7 +579,7 @@
                       xvimage[current_buf], 0, 0, image_width,
                       image_height, drwX - (vo_panscan_x >> 1),
                       drwY - (vo_panscan_y >> 1), vo_dwidth + vo_panscan_x,
-                      (vo_fs ? vo_dheight - 1 : vo_dheight) + vo_panscan_y,
+                      vo_dheight + vo_panscan_y,
                       False);
     } else
 #endif
@@ -588,7 +588,7 @@
                    xvimage[current_buf], 0, 0, image_width, image_height,
                    drwX - (vo_panscan_x >> 1), drwY - (vo_panscan_y >> 1),
                    vo_dwidth + vo_panscan_x,
-                   (vo_fs ? vo_dheight - 1 : vo_dheight) + vo_panscan_y);
+                   vo_dheight + vo_panscan_y);
     }
     if (num_buffers > 1)
     {