[MPlayer-dev-eng] [PATCH] fix detection of dvds with first aid != 128

[Aurelien Jacobs]

Hi,

I've got a problem with a dvd which has only one audio track (AC3)
but with an aid == 129 ! (I think this DVD was created with
DVDShrink)
Currently MPlayer set the aid to 128 for the first AC3 track it
dectects. It seems to be hard to fix this properly.

But anothoer problem is that dvd_aid_from_lang() always return
the first audio stream id if no lang was specified. This is
wrong. When calling dvd_aid_from_lang() you expect to get
the audio id corresponding to this lang, and not a random one
if the lang was not found. IMHO the correct behavior is to
return -1 if the lang was not found. This allows the caller
to know that this language is not available. And this then
allow the mpeg demuxer to actually select the first stream
it encounter if no one was specified.

It allows me to play my DVD without explicitely specifying
-aid 129.
I tested this with others DVDs (AC3/DTS/LPCM), with or without
-aid or -alang and everything is working as expected.
So I will commit this soon.

Aurel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dvd_default_aid.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041201/bc501ddc/attachment.txt>