[MPlayer-dev-eng] [PATCH] changes in vf semantics

[D Richard Felker III]

On Thu, Dec 02, 2004 at 04:30:30PM +0200, Ivan Kalvachev wrote:
> On Wed, 1 Dec 2004 18:01:23 -0500
> D Richard Felker III <dalias at aerifal.cx> wrote:
> 
> > On Wed, Dec 01, 2004 at 11:13:12PM +0200, Ivan Kalvachev wrote:
> > > Well well well.
> > > So, If I have understood what the already applied patch is supposed to
> > > do, is the following:
> > > At mpcodecs_config_vo() time it stores the visible dimensions, that are
> > > passed to it and later
> > > forces them to the mpi structures.
> > > This way get_image() are free to request aligned dimensions.
> > > 
> > > Well, I see sense in this modification, but I would have rejected it, as
> > > it also
> > > involves change in many places. And basically changing the philosophy of
> > > the video
> > > system.
> > > What I would have done is to align the height together with width when
> > > ALIGNED flag
> > > is set in mpi. This is nearly 2 line fix that doesn't require massive
> > > changes here and there.
> > 
> > the issue isn't alignment, it's needing border space for crap to get
> > written to. this is a different issue, imo, and the alignment system
> > isn't general enough to handle it.
> 
> Different words for same thing. What do you think alignment is for? Storing cola in it?

BTW, ROTFLMAO about storing cola in it... :))))))))))

Rich