[MPlayer-dev-eng] [PATCH] [RFC] New audio filter: LADSPA plugin loader

Diego Biurrun diego at biurrun.de
Mon Dec 13 19:10:55 CET 2004


Ivo writes:
> 
> +// libaf 

Nit: trailing whitespace, also in the files you add.

> +#define MSGTR_AF_LADSPA_WarnNoInputs "WARNING! This LADSPA plugin has no audio inputs! The incoming audio signal will be lost."
> +#define MSGTR_AF_LADSPA_ErrMultiChannel "Multi-channel (>2) plugins are not supported (yet). Use only mono and stereo plugins."

These lines are longer than 79 characters, you should break them.

> +#define MSGTR_AF_LADSPA_ErrNotEnoughControls "Not enough controls specified on the commandline!"

command line

You end a lot of your messages in an exclamation mark "!", IMO this is
a bit excessive.  Don't overuse it, only real warnings should use it.

Diego




More information about the MPlayer-dev-eng mailing list