[MPlayer-dev-eng] [PATCH] directx -colorkey support

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Thu Dec 16 22:13:28 CET 2004


On Thursday, 16 December 2004 at 21:07, Joey Parrish wrote:
> On Thu, Dec 16, 2004 at 05:53:53PM +0100, Diego Biurrun wrote:
> > On Thu, Dec 16, 2004 at 06:38:03AM -0600, Joey Parrish wrote:
> > > 
> > > Attached is a very simple patch to support the -colorkey option in
> > > vo_directx.
> > 
> > Looks simple indeed..
> > 
> > > I will commit in a couple of days if there are no objections.
> > 
> > I object!
> > 
> > > @@ -978,6 +987,7 @@
> > >      monitor_rect.right=GetSystemMetrics(SM_CXSCREEN);
> > >      monitor_rect.bottom=GetSystemMetrics(SM_CYSCREEN);
> > >  	
> > > +    windowcolor = vo_colorkey;
> > >      wc.style         =  CS_HREDRAW | CS_VREDRAW;
> > >      wc.lpfnWndProc   =  WndProc;
> > >      wc.cbClsExtra    =  0;
> > 
> > Why do you break Sascha's prettyprinting?  Align the "="...
> > 
> > SCNR ;-)
> 
> I'll align it cosmetically before I commit.
> What's SCNR stand for?

He was just pulling your leg. It stands for "Sorry, Could Not Resist",
AFAIK. ^_^

-- 
MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"




More information about the MPlayer-dev-eng mailing list