[MPlayer-dev-eng] Re: [PATCH] [REPOST] -wid: get initial window geometry

[kiriuja]

This patch has been pending since July, and I haven't seen any response,
so I am reposting it. The attached version still applies, compiles and
works.

It fixes some X11 based VOs that don't take into account the size of
the window given by the -wid option. So the video is placed unscaled in
the top left corner of the window. When the window gets a resize event,
the video takes up the entire window area. So the patch changes the
-wid part of each VO config function to get the window geometry just
like a resize event does. The affected VOs are x11, xmga, xv and xvmc.

The patch also fixes X11 based VOs that forget to map the window back
after unmapping it and changing the attributes, again when the window
is given by the -wid option. (I have no idea why it needs to be
unmapped in the first place, but I am assuming there is a reason.)
The affected VOs are xmga, xover and xvidix.

This is not a huge deal since I was able to hack around these things,
but it took me a lot of time and frustration back in the days, and I'm
sure everyone who tries to write an MPlayer frontend will struggle
badly as well. Plus sometimes the video still flickers because of this.

Please consider.

--
kiriuja
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-wid-1-2.patch
Type: text/x-diff
Size: 5216 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041217/e5bf330a/attachment.patch>